Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: replace tbl_flatten to flatten():totable() #410

Merged
merged 1 commit into from
May 22, 2024
Merged

fix: replace tbl_flatten to flatten():totable() #410

merged 1 commit into from
May 22, 2024

Conversation

pablobfonseca
Copy link
Contributor

This also fixes #408

@rcarriga
Copy link
Collaborator

Thanks for the PR!

@rcarriga rcarriga merged commit 6f35d79 into nvim-neotest:master May 22, 2024
@codymikol
Copy link
Contributor

This introduced a regression for me,

neotest-kotest: ...local/share/nvim/lazy/neotest/lua/neotest/utils/init.lua:4: E5560: vimL function must not be called in a lua loop callback
stack traceback:
	...ocal/share/nvim/lazy/neotest/lua/neotest/client/init.lua:89: in function <...ocal/share/nvim/lazy/neotest/lua/neotest/client/init.lua:88>
	[C]: in function 'has'
	...local/share/nvim/lazy/neotest/lua/neotest/utils/init.lua:4: in function 'tbl_flatten'
	...al/share/nvim/lazy/neotest/lua/neotest/lib/file/init.lua:358: in function 'match_root_pattern'
	/home/cody/dev/src/neotest-kotest/lua/neotest-kotest.lua:13: in function 'root'
	/home/cody/dev/src/neotest-kotest/lua/neotest-kotest.lua:115: in function 'build_spec'
	...al/share/nvim/lazy/neotest/lua/neotest/client/runner.lua:76: in function '_run_tree'
	...al/share/nvim/lazy/neotest/lua/neotest/client/runner.lua:65: in function <...al/share/nvim/lazy/neotest/lua/neotest/client/runner.lua:22>
	[C]: in function 'xpcall'

I'll try and do some more digging

rcarriga added a commit that referenced this pull request Jun 9, 2024
@rcarriga
fix(utils): use nio.fn
02eb256 
See #410
@rcarriga
Copy link
Collaborator

rcarriga commented Jun 9, 2024

Should be fixed in latest commit 😄

@codymikol
Copy link
Contributor

thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Deprecation warnings on neovim 0.11
3 participants
@pablobfonseca @rcarriga @codymikol